Skip to content

fix(project): throw validation error if required results is empty #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnagorra merged 19 commits into from
Oct 8, 2025
Merged

fix(project): throw validation error if required results is empty #185

tnagorra merged 19 commits into from
Oct 8, 2025

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Oct 7, 2025 •
edited
Loading

Depends on

Changes

  • Trying to publish an empty project will fail
    • Empty projects do not have tasks or groups
  • Disallow editing requesting organization after project has been published
  • Remove default value for "max task per user"
  • Allow updating "max task per user" even after project has been published
  • Add validation for "verification number" and "group size" in projects
  • Change default value for "group size" when creating a project (depends on project type)
  • Sync back "progress" and "contributor count" on firebase
  • Enable updates on paused, withdrawn and finished project
  • Update uniqueness constraint for project name

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests

@tnagorra tnagorra requested review from susilnem and thenav56 October 7, 2025 01:56
@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.73777% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.54%. Comparing base (d7e7061) to head (b60178b).
⚠️ Report is 21 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/project/serializers.py 68.42% 10 Missing and 8 partials ⚠️
apps/project/exports/exports.py 76.19% 2 Missing and 3 partials ⚠️
apps/tutorial/serializers.py 63.63% 4 Missing ⚠️
project_types/base/project.py 50.00% 1 Missing and 1 partial ⚠️
project_types/street/tests/api_calls_test.py 98.98% 1 Missing and 1 partial ⚠️
apps/common/firebase/base.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
+ Coverage    84.80%   86.54%   +1.74%     
===========================================
  Files          200      204       +4     
  Lines        11326    11769     +443     
  Branches       968      995      +27     
===========================================
+ Hits          9605    10186     +581     
+ Misses        1354     1219     -135     
+ Partials       367      364       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thenav56
thenav56 requested changes Oct 7, 2025
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susilnem
susilnem previously approved these changes Oct 7, 2025
View reviewed changes
thenav56
thenav56 previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tnagorra added 18 commits October 8, 2025 15:23
@tnagorra
fix(project): do not allow editing requesting organization later
00d8889
@tnagorra
fix(project): remove default value for "max tasks per user"
ad523a1 
- enable editing "max tasks per user" on projects later
@tnagorra
fix(project): add validation for project fields
0c15e2a 
- add validation for group size
- add validation for verification number
- add default value for group size depending on project type
- use validation for "project name"
@tnagorra
feat(project): sync project and contributorCount to firebase on update
41444b3
@tnagorra
feat(firebase): update project info on firebase after results is fetched
bc62bab
@tnagorra
fix(project): add project type on name uniqueness constraint
df373bd
@tnagorra
feat(export): add metata if maxar raster-tiles are used
43fdeea
@tnagorra
fix(firebase): fix issue with announcement sync when adding another one
0d65429 
- new annoucement was not synced because a value already existed in firebase
@tnagorra
test(project): use different raster tileserver in project mutation tests
084b4b3
@tnagorra
chore(tutorial): remove unused create method for tutorial
21a0268
@tnagorra
test(tutorial): add test for image block
cec0320
@tnagorra
test(project): add test for updating processed project
9cf46ab
@tnagorra
fix(firebase): sync maxTasksPerUser on project update
5587c75
@tnagorra
fix(project): enable editing paused, withdrawn and finished project
9558137
@tnagorra
fix(serializers): add checks for non implemented actions
be5a648
@tnagorra
refactor(config): use Config instead of settings
c337f0d
@tnagorra
test(project): add tests for street project, aggregate, geo functions
cb85897
@tnagorra
feat(filter): add "created by" filter for project and tutorial
b60178b
@tnagorra tnagorra force-pushed the fix/validation-project branch from dc94359 to b60178b Compare October 8, 2025 10:18
@tnagorra tnagorra merged commit d162d4d into develop Oct 8, 2025
6 checks passed
@tnagorra tnagorra deleted the fix/validation-project branch October 8, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thenav56 thenav56 thenav56 left review comments

@susilnem susilnem susilnem left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tnagorra @thenav56 @susilnem