Skip to content

Conversation

@sandeshit
Copy link
Contributor

Changes

  • Slack trigger for status change.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sandeshit sandeshit requested review from susilnem, thenav56 and tnagorra and removed request for thenav56 October 7, 2025 09:27
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.08%. Comparing base (68873c0) to head (c9d4229).
⚠️ Report is 9 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/project/slack_messages.py 42.85% 10 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
+ Coverage    86.57%   87.08%   +0.50%     
===========================================
  Files          204      204              
  Lines        11785    11807      +22     
  Branches       996     1004       +8     
===========================================
+ Hits         10203    10282      +79     
+ Misses        1218     1141      -77     
- Partials       364      384      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnagorra tnagorra force-pushed the feat/slack-status-trigger branch from c9d77b6 to 19d010f Compare October 8, 2025 11:47
sandeshit and others added 5 commits October 8, 2025 17:34
we can control this from slack app's configuration
This commit adds the `slack_user_id` field to the Django admin panel for the User model.
The field is now configured to be blankable but not nullable, which is the opposite of its
previous configuration.
@tnagorra tnagorra force-pushed the feat/slack-status-trigger branch from 19d010f to 6dd71b1 Compare October 8, 2025 12:25
- add merge migration
- update icon for withdrawn project
@tnagorra tnagorra force-pushed the feat/slack-status-trigger branch from 6dd71b1 to c9d4229 Compare October 8, 2025 12:28
@tnagorra tnagorra merged commit 53791ea into develop Oct 8, 2025
5 of 6 checks passed
@tnagorra tnagorra deleted the feat/slack-status-trigger branch October 8, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants