Skip to content

Conversation

@susilnem
Copy link
Member

@susilnem susilnem commented Oct 9, 2025

Addresses

  • Export e2e testing

Depends on

Changes

  • Add tests for the exports on e2e testing

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@susilnem susilnem force-pushed the feature/export-testing branch from 2a776bc to 4c6cc6a Compare October 9, 2025 06:58
@tnagorra tnagorra marked this pull request as ready for review October 10, 2025 10:51
susilnem and others added 3 commits October 10, 2025 16:40
…s_data

- ignore problematic fields/keys to pass tests (temporary)
- replace compare_csv_files to read_csv
- replace compare_geojson_files to read_json
@tnagorra tnagorra force-pushed the feature/export-testing branch from 0d5044f to c69e8f4 Compare October 10, 2025 10:56
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.55%. Comparing base (2dff549) to head (fcd7cd5).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
bulk_ignore_pyright_warnings.py 0.00% 2 Missing ⚠️
apps/project/tasks.py 0.00% 1 Missing ⚠️
.../tests/e2e_create_project_tile_map_service_test.py 98.86% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    87.05%   87.55%   +0.50%     
===========================================
  Files          204      204              
  Lines        11841    11937      +96     
  Branches      1013     1020       +7     
===========================================
+ Hits         10308    10452     +144     
+ Misses        1146     1100      -46     
+ Partials       387      385       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thenav56
thenav56 previously approved these changes Oct 10, 2025
thenav56
thenav56 previously approved these changes Oct 10, 2025
- use label instead of value for client type in results export
- use project firebase_id instead of id in history export
- read tile_x, tile_y, tile_z instead of task_x, task_y, task_z in hot tm exports
- skip flattening hot tm exports
- add url in tile map service project tasks
- fix calculation of required_count, progress
@tnagorra tnagorra force-pushed the feature/export-testing branch from 354cf61 to fcd7cd5 Compare October 10, 2025 11:23
@tnagorra tnagorra merged commit e8b3813 into develop Oct 10, 2025
6 checks passed
@tnagorra tnagorra deleted the feature/export-testing branch October 10, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants