Skip to content

Conversation

@thenav56
Copy link
Member

Addresses

  • Firebase and internal id support

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.69%. Comparing base (c145636) to head (8baf129).
⚠️ Report is 2 commits behind head on fix/validate-image-uniqueness.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/graphql/inputs.py 84.61% 1 Missing and 1 partial ⚠️
apps/community_dashboard/graphql/types.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           fix/validate-image-uniqueness     #205      +/-   ##
=================================================================
- Coverage                          87.69%   87.69%   -0.01%     
=================================================================
  Files                                204      204              
  Lines                              12209    12228      +19     
  Branches                            1032     1034       +2     
=================================================================
+ Hits                               10707    10723      +16     
- Misses                              1120     1122       +2     
- Partials                             382      383       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for firebase and internal id support for id for Contributor user and userGroup
BREAKING CHANGE: userId, userGroupId and id for contributor and
community queries are changed
@thenav56 thenav56 force-pushed the fix/firebase-and-internal-id branch from 94587b1 to e899470 Compare October 15, 2025 08:54
@thenav56 thenav56 marked this pull request as ready for review October 15, 2025 08:55
@tnagorra tnagorra merged commit 18c0659 into fix/validate-image-uniqueness Oct 15, 2025
6 checks passed
@tnagorra tnagorra deleted the fix/firebase-and-internal-id branch October 15, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants