Skip to content

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Oct 16, 2025

Depends on

Changes

  • Change bing imagery g parameter
  • Use index instead of specified numbers for scenario page, info block and info pages
  • Update slack message formatting

Details

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.69%. Comparing base (1ae590b) to head (07d6a51).
⚠️ Report is 5 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/project/slack_messages.py 25.00% 3 Missing ⚠️
project_types/base/tutorial.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
- Coverage    87.70%   87.69%   -0.01%     
===========================================
  Files          204      204              
  Lines        12237    12240       +3     
  Branches      1034     1035       +1     
===========================================
+ Hits         10732    10734       +2     
- Misses        1122     1123       +1     
  Partials       383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thenav56
thenav56 previously approved these changes Oct 16, 2025
- include project name on messages sent to channel
- remove redundant project name in base message
@tnagorra tnagorra force-pushed the fix/index-instead-of-number branch from fe8e998 to 07d6a51 Compare October 17, 2025 04:51
@thenav56 thenav56 merged commit 26c0d84 into develop Oct 17, 2025
4 of 6 checks passed
@thenav56 thenav56 deleted the fix/index-instead-of-number branch October 17, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants