Skip to content

Conversation

@tnagorra
Copy link
Collaborator

Changes

  • Filter out marked_as_deleted project assets by default
  • Add mutation to delete all uploaded project assets

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

@tnagorra tnagorra force-pushed the feat/delete-assets-bulk branch from 84010c0 to b593148 Compare October 17, 2025 09:09
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.62%. Comparing base (47ff5e5) to head (b593148).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/project/graphql/mutations.py 58.33% 5 Missing ⚠️
apps/project/graphql/queries.py 50.00% 3 Missing ⚠️
apps/tutorial/graphql/queries.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
- Coverage    87.69%   87.62%   -0.07%     
===========================================
  Files          204      204              
  Lines        12240    12260      +20     
  Branches      1035     1038       +3     
===========================================
+ Hits         10734    10743       +9     
- Misses        1123     1134      +11     
  Partials       383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

self,
info: Info,
project_id: strawberry.ID,
asset_input_type: list[ProjectAssetInputTypeEnum],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a LATER for not allow deleting AOI

)
def project_assets(
self,
include_all: bool = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenav56 thenav56 merged commit bda3677 into develop Oct 17, 2025
4 of 6 checks passed
@thenav56 thenav56 deleted the feat/delete-assets-bulk branch October 17, 2025 10:12
@thenav56
Copy link
Member

@tnagorra 👆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants