Skip to content

fix/project progress #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susilnem merged 3 commits into from
Oct 29, 2025
Merged

fix/project progress #212

susilnem merged 3 commits into from
Oct 29, 2025

Conversation

@thenav56
Copy link
Member

@thenav56 thenav56 commented Oct 29, 2025 •
edited
Loading

Addresses

  • contributor user firebase sync issue
  • project progress stuck issue

Depends on

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.66%. Comparing base (d360a9a) to head (5cef223).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
main/cronjobs.py 31.81% 15 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
+ Coverage    87.62%   87.66%   +0.03%     
===========================================
  Files          204      205       +1     
  Lines        12260    12278      +18     
  Branches      1038     1038              
===========================================
+ Hits         10743    10763      +20     
- Misses        1134     1135       +1     
+ Partials       383      380       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thenav56 thenav56 force-pushed the fix/project-progress branch from 701a74e to b83fcb0 Compare October 29, 2025 08:27
@thenav56
fix(project): fix project progress stuck at 100%
85a77a4 
Ref: https://github.com/mapswipe/python-mapswipe-workers/blob/e32dcb32410209dbf3a293218c5686d6b22ad88a/mapswipe_workers/mapswipe_workers/firebase_to_postgres/update_data.py#L570-L625
@thenav56
fix(ContributorUser): fix validation error for osm users
b83fcb0 
username is not defined for OSM users
@thenav56
fix(cronjob): replace expires with expire_seconds
5cef223 
- documentation mentioned to use expires which is compatable with both float and datetime, but internally it is processed differently
- move periodic task update to main/cronjobs.py with verbose logging

Ref:
- Documentation: https://docs.celeryq.dev/en/latest/userguide/periodic-tasks.html#beat-entries (search for options)
- Real logic: https://github.com/celery/django-celery-beat/blob/41a9da2b2fd755c24ef4b079d214dd26f8786049/django_celery_beat/schedulers.py#L215-L225
@thenav56 thenav56 marked this pull request as ready for review October 29, 2025 10:41
@susilnem susilnem merged commit 0a39913 into develop Oct 29, 2025
5 of 6 checks passed
@susilnem susilnem deleted the fix/project-progress branch October 29, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susilnem susilnem susilnem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thenav56 @susilnem