Feature/panoramax by ofr1tz · Pull Request #236 · mapswipe/mapswipe-backend

ofr1tz · 2026-02-23T16:30:40Z

Depends on

Changes

This enables the MapSwipe backend to handle View Streets projects with different image providers (currently Mapillary and Panoramax).

Adds image provider to the View Streets project specifics
Adds logic to download and process Panoramax metadata
Maps Panoramax metadata attribute names on the respective Mapillary attribute names for filtering
Changes max length of task ID to accommodate Panoramax image IDs as task IDs

This PR doesn't introduce any:

This PR contains valid:

tests
permission checks (tests here too)
translations

codecov · 2026-02-24T12:47:12Z

Codecov Report

❌ Patch coverage is 87.89809% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.46%. Comparing base (6c9dd95) to head (3089d82).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
utils/geo/street_image_provider/models.py	68.75%	6 Missing and 4 partials ⚠️
project_types/street/api_calls.py	87.09%	2 Missing and 2 partials ⚠️
project_types/street/project.py	80.00%	2 Missing and 2 partials ⚠️
...ps/project/tests/e2e_create_street_project_test.py	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    87.41%   87.46%   +0.04%     
===========================================
  Files          205      206       +1     
  Lines        12458    12579     +121     
  Branches      1049     1067      +18     
===========================================
+ Hits         10890    11002     +112     
- Misses        1181     1186       +5     
- Partials       387      391       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

susilnem · 2026-03-10T08:10:25Z

project_types/street/project.py

        return firebase_models.FbMappingTaskStreetCreateOnlyInput(
-            # XXX: converting this to int for backwards compatibility
-            taskId=int(task.firebase_id),
+            taskId=task.firebase_id,


Is there any reason to remove the casting of firebase_id?

Yes, we use the street-level image ID as the MapSwipe task ID so that we can easily link MapSwipe results back to the original images without having to add an additional task attribute.

However, whereas Mapillary has integer image identifiers, Panoramax uses UUID v4 for identifiers.

We should still cast it to int for backward compatibility if the provider is Mapillary

utils/spatial_sampling.py

susilnem · 2026-03-10T08:16:27Z

utils/geo/street_image_provider/models.py

Shouldn't this be in street/project.py?

This is consistent with raster_tile_server and vector_tile_server also in utils/geo/

utils/geo/street_image_provider/models.py

project_types/street/api_calls.py

susilnem · 2026-03-11T05:43:08Z

apps/project/models.py


    # Type hints
-    id: int
+    id: int | str


Any reason on changing the type?

Same as above: task id == Panoramax image ID (UUID v4)

This is just a type hint.
How was "id" change to "str" in the database.

Also, why change the internal "id" representation?

I see. This was a mix-up with the firebase ID, the internal id representation does not need to be changed indeed.

project_types/street/project.py

Add logic from mapswipe/python-mapswipe-workers@dev...panoramax and refactor StreetImageProvider. This introduces a type change of View Streets project tasks taskId that requires migration and changes in Firebase.

…oramax ids

…nsure correct sorting, sampling threshhold input in m instead km

…pano

Co-authored-by: Sushil Tiwari <susiltiwari750@gmail.com>

…ke name required

…ovider name)

tnagorra · 2026-04-02T05:55:35Z

apps/project/models.py


    # Type hints
-    id: int
+    id: int | str


This is just a type hint.
How was "id" change to "str" in the database.

Also, why change the internal "id" representation?

tnagorra · 2026-04-02T05:58:00Z

project_types/street/api_calls.py

+    else:
+        raise Exception(f"Unknown provider {getattr(provider.name, 'value', '')}")


Use assert_never so that we get static type checks.

tnagorra · 2026-04-02T06:02:20Z

schema.graphql

  endTime: String
-  isPano: Boolean
  organizationId: String
+  panoOnly: Boolean


This might require a migration.

To my understanding:

A migration is not required as the attribute is stored in JSON fields, not in a dedicated column

We probably do not need a backfill neither, as this would only be a potential issue for unpublished project drafts created with the former version having isPano: true. The filter is only used during project processing.

tnagorra · 2026-04-02T06:02:22Z

schema.graphql

  """Numeric value as string"""
  aoiGeometry: String!
  customOptions: [CustomOptionInput!] = null
+  imageProvider: StreetImageProviderInput = null


This might require a migration.

This is a nested key inside the JSON field project_type_specifics and does not create a new column.

Backend treats it as optional and defaults to MAPILLARY, so existing records without imageProvider continue to validate.

tnagorra · 2026-04-02T06:02:24Z

schema.graphql

  """Numeric value as string"""
  aoiGeometry: String!
  customOptions: [ProjectCustomOption!]
+  imageProvider: StreetImageProvider


This might require a migration.

tnagorra · 2026-04-02T06:10:20Z

project_types/street/project.py

        return firebase_models.FbMappingTaskStreetCreateOnlyInput(
-            # XXX: converting this to int for backwards compatibility
-            taskId=int(task.firebase_id),
+            taskId=task.firebase_id,


We should still cast it to int for backward compatibility if the provider is Mapillary

…ider is mapillary, correct type hint

ofr1tz mentioned this pull request Feb 24, 2026

Feature/panoramax mapswipe/manager-dashboard#74

Open

9 tasks

ofr1tz marked this pull request as ready for review February 24, 2026 17:42

frozenhelium requested a review from susilnem March 6, 2026 08:09

susilnem requested changes Mar 11, 2026

View reviewed changes

ofr1tz added 21 commits March 19, 2026 16:36

feature(street): add image provider in schema

fae7dfd

feat(street): add panoramax as image provider

bca81b2

Add logic from mapswipe/python-mapswipe-workers@dev...panoramax and refactor StreetImageProvider. This introduces a type change of View Streets project tasks taskId that requires migration and changes in Firebase.

feat(street): update firebase submodule pointer

119cf5c

feat(street): update schema for image provider selection

8f67526

feat(street): extend firebase_id char length to 36 to accommodate pan…

6032034

…oramax ids

feat(street): use safe image provider api url

26ab735

feat(street): update submodule pointer

08075fa

feat(street): update submodule pointer

68a84da

feat(street): add image provider to firebase project type specifics

5b968c3

feat(street): add image provider to firebase tutorial

688f171

feat(street): Correctly convert Mapillary and Panoramax timestamps, e…

172cf0e

…nsure correct sorting, sampling threshhold input in m instead km

fix(street): format and typechecks

408a6e8

feat(street): submodule pointer for updated test assets

8a2546d

feat(street): fix tests

9936f03

feat(street): improve cov

e4d4fc8

feat(streets): format

c94dfa4

feat(street): fix test

66cb605

feat(street): update submodule pointers

05ede22

feat(street): add panoramax custom to enum, use pano_only instead is_…

30ef921

…pano

fix(street): formatting

35605b9

fix(street): ruff errors

f15f817

ofr1tz force-pushed the feature/panoramax branch from 71352ae to f15f817 Compare March 19, 2026 15:50

ofr1tz and others added 3 commits March 19, 2026 17:14

fix(street): adjust tests

c3c251b

feat(street): remove url from provider if Mapillary

d307d24

Update utils/spatial_sampling.py

4dc301c

Co-authored-by: Sushil Tiwari <susiltiwari750@gmail.com>

ofr1tz added 3 commits March 23, 2026 16:28

refactor(street): move tile level logic to StreetImageProvider and ma…

cf75ff4

…ke name required

feat(street): update graphql schema

c924b01

test(street): update test assets to reflect changes (default image pr…

036888a

…ovider name)

ofr1tz requested a review from susilnem March 23, 2026 16:06

ofr1tz force-pushed the feature/panoramax branch 2 times, most recently from a2dad0a to f15f817 Compare March 23, 2026 16:53

tnagorra requested changes Apr 2, 2026

View reviewed changes

ofr1tz added 3 commits April 2, 2026 10:41

fix(street): Use assert_never, cast firebase task id to int when prov…

cfd7c79

…ider is mapillary, correct type hint

fix(street): update firebase submodule pointer

3550252

fix(street): update e2e test, firebase submodule pointer

3089d82

		else:
		raise Exception(f"Unknown provider {getattr(provider.name, 'value', '')}")

Conversation

ofr1tz commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

This PR doesn't introduce any:

This PR contains valid:

Uh oh!

codecov bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ofr1tz Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ofr1tz commented Feb 23, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited

Loading

ofr1tz Apr 2, 2026 •

edited

Loading