Skip to content

Conversation

@susilnem
Copy link
Member

@susilnem susilnem commented Jul 15, 2025

Changes

  • Add asset for project and tutorial
  • Add validations checks for asset
  • Different serializers for the tutorials for create and update
  • Update test cases
  • Add checks for the status validations

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@susilnem susilnem changed the title Feature: Tutorial State Transition Feature: Tutorial state transition and asset Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.69%. Comparing base (832e743) to head (cc25d41).
⚠️ Report is 12 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/common/models.py 81.81% 7 Missing and 1 partial ⚠️
apps/common/serializers.py 68.00% 4 Missing and 4 partials ⚠️
apps/tutorial/serializers.py 80.00% 3 Missing and 1 partial ⚠️
apps/tutorial/models.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
- Coverage    81.80%   81.69%   -0.12%     
===========================================
  Files          145      145              
  Lines         5930     6020      +90     
  Branches       515      521       +6     
===========================================
+ Hits          4851     4918      +67     
- Misses         905      927      +22     
- Partials       174      175       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susilnem susilnem marked this pull request as ready for review July 23, 2025 04:46
@susilnem susilnem force-pushed the feature/assest-validations branch from a966cad to c74bd2f Compare July 23, 2025 06:31
@tnagorra tnagorra changed the title Feature: Tutorial state transition and asset Breaking! Tutorial state transition and asset Jul 28, 2025
@susilnem susilnem force-pushed the feature/assest-validations branch 2 times, most recently from f600c7d to bc68ef1 Compare July 29, 2025 08:19
@tnagorra
Copy link
Collaborator

@frozenhelium We need to also work on the frontend before we can merge this.
This will impact how we create and edit tutorial.

tnagorra
tnagorra previously approved these changes Jul 30, 2025
tnagorra
tnagorra previously approved these changes Jul 30, 2025
tnagorra
tnagorra previously approved these changes Jul 30, 2025
@tnagorra tnagorra force-pushed the feature/assest-validations branch from 118ffc8 to f21bdee Compare July 30, 2025 13:22
@tnagorra tnagorra force-pushed the feature/assest-validations branch from 6bcbb3e to 946f358 Compare July 31, 2025 02:26
@tnagorra tnagorra force-pushed the feature/assest-validations branch from 6743db3 to cc25d41 Compare July 31, 2025 02:48
@tnagorra tnagorra merged commit 27c910d into develop Jul 31, 2025
6 checks passed
@tnagorra tnagorra deleted the feature/assest-validations branch July 31, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants