Skip to content

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jul 16, 2025

Changes

  • Add validation when archived non empty contributor team

Depends on

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/archive-team-validation branch 2 times, most recently from e0d538f to c41433a Compare July 16, 2025 10:57
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 75.24752% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.55%. Comparing base (51bdcab) to head (bc8ab4a).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/common/admin.py 54.00% 20 Missing and 3 partials ⚠️
apps/contributor/factories.py 83.33% 1 Missing ⚠️
apps/contributor/models.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
- Coverage    82.68%   82.55%   -0.14%     
===========================================
  Files          141      143       +2     
  Lines         5695     5795     +100     
  Branches       486      494       +8     
===========================================
+ Hits          4709     4784      +75     
- Misses         825      846      +21     
- Partials       161      165       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the base branch from develop to feature/archive-project July 16, 2025 11:03
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 16, 2025 11:07
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

Base automatically changed from feature/archive-project to develop July 17, 2025 04:28
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/archive-team-validation branch 2 times, most recently from c189ae5 to dd7170e Compare July 17, 2025 10:39
@tnagorra tnagorra marked this pull request as draft July 21, 2025 08:39
Copy link
Collaborator

@tnagorra tnagorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "archivedBy" and "archivedAt" fields should be automatically populated when archiving/un-archiving team.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 21, 2025 09:50
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as draft July 21, 2025 09:51
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 21, 2025 10:45
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as draft July 21, 2025 10:46
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/archive-team-validation branch from 2519786 to 2ed533c Compare July 22, 2025 08:40
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 22, 2025 08:51
Copy link
Collaborator

@tnagorra tnagorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this PR add archivable in project and organization?

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/archive-team-validation branch 3 times, most recently from 11eb8f4 to 7e83fb4 Compare July 29, 2025 04:33
@tnagorra tnagorra force-pushed the feature/archive-team-validation branch from 7e83fb4 to bc8ab4a Compare July 29, 2025 04:45
@tnagorra tnagorra merged commit 3d01232 into develop Jul 29, 2025
3 of 5 checks passed
@tnagorra tnagorra deleted the feature/archive-team-validation branch July 29, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants