Skip to content

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jul 18, 2025

Changes

  • sync organization data into firebase.

Depends on

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-org-to-firebase branch from b598d6d to 338e087 Compare July 18, 2025 11:10
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-org-to-firebase branch from 338e087 to 2d65a81 Compare July 23, 2025 11:23
@susilnem susilnem marked this pull request as ready for review July 25, 2025 06:01
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-org-to-firebase branch 2 times, most recently from 8c38787 to 9f03766 Compare July 25, 2025 08:30
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

Attention: Patch coverage is 50.79365% with 31 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (76821d8) to head (ce454ab).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/project/firebase.py 37.20% 27 Missing ⚠️
apps/project/models.py 50.00% 3 Missing ⚠️
main/config.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
- Coverage    82.82%   82.69%   -0.13%     
===========================================
  Files          140      141       +1     
  Lines         5584     5647      +63     
  Branches       479      485       +6     
===========================================
+ Hits          4625     4670      +45     
- Misses         798      828      +30     
+ Partials       161      149      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susilnem susilnem force-pushed the feature/sync-org-to-firebase branch from 456a5c8 to ce454ab Compare July 25, 2025 12:18
@susilnem susilnem merged commit db292b0 into develop Jul 25, 2025
3 of 5 checks passed
@susilnem susilnem deleted the feature/sync-org-to-firebase branch July 25, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants