Skip to content

Conversation

@tnagorra
Copy link
Collaborator

Changes

  • sync source_layer to firebase for completeness project
  • rename source_name to source_layer for vector layer

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@tnagorra tnagorra requested a review from frozenhelium July 30, 2025 03:04
@tnagorra tnagorra changed the title fix(completeness)!: sync source_layer to firebase for completeness pr… Sync source_layer to firebase for completeness project Jul 30, 2025
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.31%. Comparing base (d624848) to head (b7ae327).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/geo/vector_tile_server/models.py 47.61% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
- Coverage    82.43%   82.31%   -0.13%     
===========================================
  Files          143      143              
  Lines         5791     5807      +16     
  Branches       497      500       +3     
===========================================
+ Hits          4774     4780       +6     
- Misses         849      859      +10     
  Partials       168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnagorra tnagorra force-pushed the fix/source-layer-completeness branch from a603717 to b7ae327 Compare July 30, 2025 04:31
@tnagorra tnagorra merged commit 1e2c61b into develop Jul 30, 2025
4 of 6 checks passed
@tnagorra tnagorra deleted the fix/source-layer-completeness branch July 30, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants