Skip to content

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jul 30, 2025

Depends on

Changes

  • add team members when create or update team.
  • add base class for firebase sync feature
  • modify organization sync to firebase according to new class.
  • add management command to create dummy contributor user.
  • add link to view contributor users in team row.
  • allow to update only team in contributor admin form.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-team-member-to-firebase branch 4 times, most recently from 1b23a43 to b26732d Compare July 31, 2025 11:11
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 73.40426% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.05%. Comparing base (5e145f6) to head (c24bd9d).
⚠️ Report is 10 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/common/firebase.py 44.44% 22 Missing and 3 partials ⚠️
apps/contributor/firebase.py 75.00% 9 Missing and 1 partial ⚠️
apps/contributor/admin.py 66.66% 6 Missing ⚠️
apps/project/firebase.py 76.19% 5 Missing ⚠️
apps/common/admin.py 57.14% 3 Missing ⚠️
main/config.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #83      +/-   ##
===========================================
+ Coverage    81.68%   82.05%   +0.36%     
===========================================
  Files          145      145              
  Lines         6045     6086      +41     
  Branches       523      517       -6     
===========================================
+ Hits          4938     4994      +56     
+ Misses         931      911      -20     
- Partials       176      181       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-team-member-to-firebase branch 2 times, most recently from 12c61bc to 0663af2 Compare July 31, 2025 11:24
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review July 31, 2025 11:27
@tnagorra tnagorra marked this pull request as draft August 1, 2025 06:21
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review August 1, 2025 06:32
tnagorra
tnagorra previously approved these changes Aug 1, 2025
@tnagorra tnagorra self-requested a review August 1, 2025 09:01
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-team-member-to-firebase branch from 0f889f6 to 410acf5 Compare August 1, 2025 11:12
@tnagorra tnagorra force-pushed the feature/sync-team-member-to-firebase branch from 410acf5 to 6ea3b9b Compare August 1, 2025 14:22
tnagorra
tnagorra previously approved these changes Aug 1, 2025
Rup-Narayan-Rajbanshi and others added 8 commits August 1, 2025 22:35
  - Add field old id in teams
  - Refactor project to accept base firebase resources.
- disable adding/deleting contributor user
- add a reusable mixing for readonly admin interface
- only allow editing teamId of contributor user during firebase update
- disallow creating contributor user on backend
- fix issue with firebase key for tasks
- Add link to view contributor users in team row.
- Allow to update only team in contributor admin form.
- remove canonical_id and use firebase_id instead
- rename legacy_task_id to firebase_id
- rename legacy_group_id to firebase_id
- add resuable models: FirebasePushModel, FirebasePullModel
@tnagorra tnagorra force-pushed the feature/sync-team-member-to-firebase branch from 6ea3b9b to c24bd9d Compare August 1, 2025 16:58
@tnagorra tnagorra merged commit 87cc628 into develop Aug 1, 2025
5 of 6 checks passed
@tnagorra tnagorra deleted the feature/sync-team-member-to-firebase branch August 1, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants