Skip to content

Conversation

@susilnem
Copy link
Member

Addresses

  • validation checks for the geojson asset file

Changes

  • Add new validation check for geojson
  • Update validation check for geojson asset file in serializer

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.67%. Comparing base (90f7bdd) to head (deec09b).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/common.py 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
- Coverage    81.70%   81.67%   -0.03%     
===========================================
  Files          145      145              
  Lines         6028     6040      +12     
  Branches       521      523       +2     
===========================================
+ Hits          4925     4933       +8     
- Misses         928      931       +3     
- Partials       175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnagorra tnagorra force-pushed the feature/validate-asset branch from b2ab179 to 011d489 Compare July 31, 2025 08:30
@tnagorra tnagorra force-pushed the feature/validate-asset branch from 011d489 to deec09b Compare July 31, 2025 08:39
@tnagorra tnagorra merged commit c1fc459 into develop Jul 31, 2025
4 of 6 checks passed
@tnagorra tnagorra deleted the feature/validate-asset branch July 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants