Skip to content

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Aug 3, 2025

Depends on

Changes

  • Add FirebaseResourceAdmin for firebase resources.
  • Add firebase class to sync user group data when create and update.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title Feature/sync user group to firebase Firebase: Sync user group to firebase Aug 3, 2025
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title Firebase: Sync user group to firebase Firebase: Sync user group Aug 3, 2025
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-user-group-to-firebase branch from b249b72 to 8fe0d9c Compare August 3, 2025 10:32
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

❌ Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.10%. Comparing base (5cc5cc7) to head (81d4d04).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/contributor/firebase.py 72.22% 4 Missing and 1 partial ⚠️
apps/common/admin.py 60.00% 2 Missing ⚠️
apps/contributor/admin.py 80.00% 1 Missing ⚠️
main/config.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    80.10%   80.10%   -0.01%     
===========================================
  Files          146      146              
  Lines         6529     6564      +35     
  Branches       549      550       +1     
===========================================
+ Hits          5230     5258      +28     
- Misses        1109     1115       +6     
- Partials       190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/sync-user-group-to-firebase branch 2 times, most recently from af70d32 to 9dd1280 Compare August 3, 2025 13:30
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review August 3, 2025 13:44
tnagorra
tnagorra previously approved these changes Aug 4, 2025
tnagorra
tnagorra previously approved these changes Aug 4, 2025
@tnagorra tnagorra force-pushed the feature/sync-user-group-to-firebase branch from 868887c to 81d4d04 Compare August 4, 2025 15:22
@tnagorra tnagorra merged commit 7e35f6c into develop Aug 4, 2025
6 checks passed
@tnagorra tnagorra deleted the feature/sync-user-group-to-firebase branch August 4, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants