Skip to content

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Aug 3, 2025

Depends on

Changes

  • Setup base class for pushing tutorial data to firebase
  • Setup class for pushing find tutorial data to firebase
  • Setup class for pushing compare tutorial data to firebase
  • Setup class for pushing completeness tutorial data to firebase
  • Setup class for pushing validate tutorial data to firebase

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@tnagorra tnagorra changed the title fix(firebase): update key used for group and task references feat: push firebase data for validate tutorial Aug 3, 2025
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

❌ Patch coverage is 48.63946% with 151 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@7187c10). Learn more about missing BASE report.
⚠️ Report is 7 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
project_types/base/tutorial.py 33.64% 66 Missing and 5 partials ⚠️
project_types/tile_map_service/base/tutorial.py 40.00% 18 Missing ⚠️
...ct_types/tile_map_service/completeness/tutorial.py 51.72% 14 Missing ⚠️
project_types/validate/tutorial.py 63.63% 12 Missing ⚠️
project_types/tile_map_service/compare/tutorial.py 57.69% 11 Missing ⚠️
project_types/tile_map_service/find/tutorial.py 62.50% 9 Missing ⚠️
apps/tutorial/models.py 56.25% 7 Missing ⚠️
project_types/firebase.py 28.57% 5 Missing ⚠️
main/config.py 80.00% 3 Missing ⚠️
apps/common/firebase.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #91   +/-   ##
==========================================
  Coverage           ?   80.10%           
==========================================
  Files              ?      146           
  Lines              ?     6529           
  Branches           ?      549           
==========================================
  Hits               ?     5230           
  Misses             ?     1109           
  Partials           ?      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thenav56
thenav56 previously approved these changes Aug 3, 2025
@tnagorra tnagorra changed the title feat: push firebase data for validate tutorial feat: push firebase data for find, compare, completensss and validate tutorial Aug 3, 2025
@tnagorra tnagorra force-pushed the feat/firebase-push-validate branch from ecf3219 to 973c092 Compare August 3, 2025 16:41
thenav56
thenav56 previously approved these changes Aug 4, 2025
@tnagorra tnagorra force-pushed the feat/firebase-push-validate branch from 973c092 to b80fc24 Compare August 4, 2025 13:46
- setup class to push validate tutorial to firebase
    - tutorial
    - group
    - task
- add "identifier" in tutorial task
- remove validation for "object_geometry" in tutorial task
- update firebase path functions to only support str args
…ta to firebase

- add sorting of tasks for find/compare/completeness
@tnagorra tnagorra force-pushed the feat/firebase-push-validate branch from b80fc24 to 5cc5cc7 Compare August 4, 2025 13:49
@tnagorra tnagorra merged commit a4cec84 into develop Aug 4, 2025
6 checks passed
@tnagorra tnagorra deleted the feat/firebase-push-validate branch August 4, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants