Skip to content

fix(user): change username to optional field #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susilnem merged 1 commit into from
Oct 29, 2025
Merged

fix(user): change username to optional field #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions functions/definition/user.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ FbUserReadonlyType:
optional: true
username:
type: string
optional: true # XXX: For OSM users this is not provided
usernameKey:
# NOTE: web does not set usernameKey
type: string
Expand Down
4 changes: 3 additions & 1 deletion functions/generated/pyfirebase/pyfirebase_mapswipe/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ class FbUserReadonlyType(TypesyncModel):
str | TypesyncUndefined | None,
pydantic.Field(deprecated=True),
] = UNDEFINED
username: str
username: str | TypesyncUndefined | None = UNDEFINED
usernameKey: str | TypesyncUndefined | None = UNDEFINED
accessibility: bool | TypesyncUndefined | None = UNDEFINED
userGroups: dict[str, typing.Any] | TypesyncUndefined | None = UNDEFINED
Expand All @@ -1137,6 +1137,8 @@ def __setattr__(self, name: str, value: typing.Any) -> None:
raise ValueError("'userName' field cannot be set to None")
if name == "userNameKey" and value is None:
raise ValueError("'userNameKey' field cannot be set to None")
if name == "username" and value is None:
raise ValueError("'username' field cannot be set to None")
if name == "usernameKey" and value is None:
raise ValueError("'usernameKey' field cannot be set to None")
if name == "accessibility" and value is None:
Expand Down
Loading