Skip to content

Fix community dashboard for street project stats #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnagorra merged 1 commit into from
Mar 11, 2025
Merged

Fix community dashboard for street project stats #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions community-dashboard/app/views/StatsBoard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ const BUILD_AREA = 'BUILD_AREA';
const FOOTPRINT = 'FOOTPRINT';
const CHANGE_DETECTION = 'CHANGE_DETECTION';
const COMPLETENESS = 'COMPLETENESS';
const STREET = 'STREET';

// FIXME: the name property is not used properly
const projectTypes: Record<string, { color: string, name: string }> = {
[UNKNOWN]: {
color: '#808080',
color: '#cacaca',
name: 'Unknown',
},
[BUILD_AREA]: {
Expand All @@ -92,6 +94,10 @@ const projectTypes: Record<string, { color: string, name: string }> = {
color: '#fb8072',
name: 'Completeness',
},
[STREET]: {
color: '#808080',
name: 'Street',
},
};

type ResolutionType = 'day' | 'month' | 'year';
Expand Down Expand Up @@ -372,7 +378,11 @@ function StatsBoard(props: Props) {
swipeByProjectType
?.map((item) => ({
...item,
projectType: item.projectType ?? '-1',
projectType: (
isDefined(item.projectType)
&& isDefined(projectTypes[item.projectType])
) ? item.projectType
: UNKNOWN,
}))
.sort((a, b) => compareNumber(a.totalSwipes, b.totalSwipes, -1)) ?? []
),
Expand Down Expand Up @@ -750,7 +760,7 @@ function StatsBoard(props: Props) {
{sortedProjectSwipeType.map((item) => (
<Cell
key={item.projectType}
fill={projectTypes[item.projectType].color}
fill={projectTypes[item.projectType]?.color}
/>
))}
</Pie>
Expand Down
Loading