Skip to content

fix: chart in projects page #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaKhatri merged 1 commit into from
Oct 15, 2025
Merged

fix: chart in projects page #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/ProjectsMap/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function ProjectMap(props: Props) {
<Link
className={styles.cardLink}
key={project.id}
href={`/[locale]/projects/${project.id}`}
href={`/[locale]/projects/${project.firebaseId}`}
>
<Card
className={styles.project}
Expand Down Expand Up @@ -215,12 +215,12 @@ function ProjectMap(props: Props) {
<div className={styles.progressBar}>
<div className={styles.track}>
<div
style={{ width: `${project.progress}%` }}
style={{ width: `${project.progress * 100}%` }}
className={styles.progress}
/>
</div>
<div className={styles.progressLabel}>
{t('project-card-progress-text', { progress: project.progress })}
{t('project-card-progress-text', { progress: (project.progress * 100) })}
</div>
</div>
)}
Expand Down
33 changes: 19 additions & 14 deletions src/pages/[locale]/projects/[id].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import React, { useEffect, useState, useMemo } from 'react';
import dynamic from 'next/dynamic';
import { GetStaticProps, GetStaticPaths } from 'next';
import { useTranslation } from 'next-i18next';
import { _cs, bound, listToMap } from '@togglecorp/fujs';
import {
_cs,
bound,
listToMap,
isDefined,
} from '@togglecorp/fujs';
import { serverSideTranslations } from 'next-i18next/serverSideTranslations';
import {
IoDownloadOutline,
Expand Down Expand Up @@ -449,11 +454,11 @@ function Project(props: Props) {
</div>
</div>
<div className={styles.chartContainer}>
{chartPoints.length > 1 ? (
<div
ref={svgContainerRef}
className={styles.timelineChartContainer}
>
<div
ref={svgContainerRef}
className={styles.timelineChartContainer}
>
{(isDefined(projectHistory) && chartPoints.length > 1) ? (
<svg className={styles.timelineChart}>
<defs>
<linearGradient
Expand Down Expand Up @@ -522,15 +527,15 @@ function Project(props: Props) {
d={getPathData(chartPoints)}
/>
</svg>
</div>
) : (
<div className={styles.emptyChart}>
<IoStatsChartSharp className={styles.chartIcon} />
<div className={styles.message}>
Not enough data points for the chart!
) : (
<div className={styles.emptyChart}>
<IoStatsChartSharp className={styles.chartIcon} />
<div className={styles.message}>
Not enough data points for the chart!
</div>
</div>
</div>
)}
)}
</div>
</div>
</div>
</Section>
Expand Down
Loading