RD-1496 Fix global styles #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katemihalikova
force-pushed
the
RD-1292-RD-1293-leaflet
branch
from
f1ac04d to
1f63654
Compare
katemihalikova
force-pushed
the
RD-1496-fix-global-styles
branch
from
7b2d80d to
18c9625
Compare
lesbaa
approved these changes
Dec 8, 2025
Contributor
lesbaa
left a comment
lesbaa
left a comment
There was a problem hiding this comment.
Few minor comments, otherwise LGTM 👍
katemihalikova
force-pushed
the
RD-1496-fix-global-styles
branch
from
18c9625 to
04e0808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-1496
Objective
Fix global styles not being applied (mostly icon colors)
Description
Svelte uses non-standard styling system, this PR changes it into standard-compliant way using
:host()selector. This also introducesopenListOnTopoption that configures if the results list should be opened above query input instead of below. Since styles are now encapsulated in shadow DOM,classoptions has been removed and will be replaced with css props and/or slots in the future.Acceptance
Manual testing
This PR is opened against one of the refactoring branch as to not clutter the #101 + #103 pull requests even more. Merge this into
nextonly after #101 + #103 are merged intonext.