-
Notifications
You must be signed in to change notification settings - Fork 23
RD-1396 migrate AnimatedRouteLayer and MapTilerAnimation to main repo
#279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AnimatedRouteLayer and MapTilerAnimation to main repo
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
|
/update-snapshots |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
…ng-to-main-repo)
katemihalikova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job! The API is nice and well‑structured, seems to integrate well. Like the keyframe engine behind it. There are just few minor problems that I found out when reading the PR or when testing the examples provided.
|
Some E2E Tests Failed: Please check the attached artifacts here |
|
/update-snapshots |
|
/update-snapshots |
katemihalikova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the default value of pathSmoothing option not being used I haven't found any other problem, the demos run fine even with some slight modifications. I think we are good to go after the default option is fixed!
|
/update-snapshots |
|
Some E2E Tests Failed: Please check the attached artifacts here |
0be7587 to
32df581
Compare
|
Some E2E Tests Failed: Please check the attached artifacts here |
Objective
MapTilerAnimationclass for managing animationsAnimatedRouteLayerfor animating routes.Description
Adds the above modules, their helper functions and tests
Acceptance
Unit and e2e tests.
Checklist