RD-1718 Enable terrain on render if style already loaded#321
Open
katemihalikova wants to merge 1 commit intonextfrom
Open
RD-1718 Enable terrain on render if style already loaded#321katemihalikova wants to merge 1 commit intonextfrom
katemihalikova wants to merge 1 commit intonextfrom
Conversation
| }; | ||
|
|
||
| this.once("load", () => { | ||
| this.once(this.style._loaded ? "render" : "load", () => { |
There was a problem hiding this comment.
It looks like a solid fix. But will it work in case that style is done loading but data are still loading?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix a bug that prevented terrain being turned on immediately
Description
Using "render" event instead of "moveend" if style is loaded.
Acceptance
Manual testing
Checklist