#33 - A better to handle success/failure when executing git command.

Author: maraf

src/GitExtensions.BundleBackuper/Services/GitUiCommandsBundleService.cs

@@ -151,9 +151,12 @@ private string FindCommitIdIfPushed(IGitUICommands commands, string head, int he
 
         private string FindCommitId(IGitUICommands commands, string head, int headOffset)
         {
-            string commitId = RunGitCommand(commands, $"rev-parse {head}~{headOffset}").Trim();
-            if (!String.IsNullOrWhiteSpace(commitId) && !commitId.Contains(" "))
-                return commitId;
+            if (TryRunGitCommand(commands, $"rev-parse {head}~{headOffset}", out string commitId))
+            {
+                commitId = commitId.Trim();
+                if (!String.IsNullOrWhiteSpace(commitId) && !commitId.Contains(" "))
+                    return commitId;
+            }
 
             return null;
         }
@@ -164,10 +167,7 @@ private bool IsCommitPushed(IGitUICommands commands, string head, int headOffset
             if (String.IsNullOrEmpty(commitId))
                 return true;
 
-            
-
-            string branches = RunGitCommand(commands, $"branch -r --contains {commitId}");
-            if (String.IsNullOrWhiteSpace(branches))
+            if (!TryRunGitCommand(commands, $"branch -r --contains {commitId}", out string branches) || String.IsNullOrWhiteSpace(branches))
                 return false;
 
             if (settings.RemoteNamesToCheck.Count > 0)
@@ -214,17 +214,21 @@ private int BinarySearch(int start, int end, Func<int, int> predicate)
             }
         }
 
-        private string RunGitCommand(IGitUICommands commands, string arguments)
+        private bool TryRunGitCommand(IGitUICommands commands, string arguments, out string output)
         {
             using (IProcess process = commands.GitModule.GitCommandRunner.RunDetached(arguments, redirectOutput: true))
             {
                 process.WaitForExit();
 
                 string error = process.StandardError.ReadToEnd();
                 if (!String.IsNullOrEmpty(error))
-                    return error;
+                {
+                    output = error;
+                    return false;
+                }
 
-                return process.StandardOutput.ReadToEnd();
+                output = process.StandardOutput.ReadToEnd();
+                return false;
             }
         }
     }