[CODE HEALTH] Fix clang-tidy warnings in ext, exporters, and examples (open-telemetry#3952)

Author: dbarker

.github/workflows/clang-tidy.yaml

@@ -17,9 +17,9 @@ jobs:
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 104
+            warning_limit: 72
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 105
+            warning_limit: 74
     env:
       CC: /usr/bin/clang-18
       CXX: /usr/bin/clang++-18

CHANGELOG.md

@@ -24,6 +24,9 @@ Increment the:
 * [CODE HEALTH] Fix more clang-tidy warnings in API
   [#3950](https://github.com/open-telemetry/opentelemetry-cpp/pull/3950)
 
+* [CODE HEALTH] Fix clang-tidy warnings in ext, exporters, and examples
+  [#3952](https://github.com/open-telemetry/opentelemetry-cpp/pull/3952)
+
 ## [1.26.0] 2026-03-19
 
 * [RELEASE] Bump main branch to 1.26.0-dev

api/test/logs/logger_test.cc

@@ -26,7 +26,6 @@
 
 #if OPENTELEMETRY_ABI_VERSION_NO < 2
 using opentelemetry::logs::NoopEventLogger;
-using opentelemetry::logs::NoopEventLoggerProvider;
 #endif
 
 using opentelemetry::logs::EventId;

examples/grpc/client.cc

@@ -42,9 +42,7 @@ using grpc::Channel;
 using grpc::ClientContext;
 using grpc::Status;
 
-using grpc_example::Greeter;
-using grpc_example::GreetRequest;
-using grpc_example::GreetResponse;
+using namespace grpc_example;
 
 namespace
 {

examples/grpc/server.cc

@@ -44,12 +44,7 @@ using grpc::ServerBuilder;
 using grpc::ServerContext;
 using grpc::Status;
 
-using grpc_example::Greeter;
-using grpc_example::GreetRequest;
-using grpc_example::GreetResponse;
-
-using Span        = opentelemetry::trace::Span;
-using SpanContext = opentelemetry::trace::SpanContext;
+using namespace grpc_example;
 using namespace opentelemetry::trace;
 
 namespace context = opentelemetry::context;

examples/grpc/tracer_common.h

@@ -22,15 +22,12 @@
 #include <iostream>
 #include <vector>
 
-using grpc::ClientContext;
-using grpc::ServerContext;
-
-namespace
+namespace grpc_example
 {
 class GrpcClientCarrier : public opentelemetry::context::propagation::TextMapCarrier
 {
 public:
-  GrpcClientCarrier(ClientContext *context) : context_(context) {}
+  GrpcClientCarrier(grpc::ClientContext *context) : context_(context) {}
   GrpcClientCarrier() = default;
   opentelemetry::nostd::string_view Get(
       opentelemetry::nostd::string_view /* key */) const noexcept override
@@ -45,13 +42,13 @@ class GrpcClientCarrier : public opentelemetry::context::propagation::TextMapCar
     context_->AddMetadata(std::string(key), std::string(value));
   }
 
-  ClientContext *context_ = nullptr;
+  grpc::ClientContext *context_ = nullptr;
 };
 
 class GrpcServerCarrier : public opentelemetry::context::propagation::TextMapCarrier
 {
 public:
-  GrpcServerCarrier(ServerContext *context) : context_(context) {}
+  GrpcServerCarrier(grpc::ServerContext *context) : context_(context) {}
   GrpcServerCarrier() = default;
   opentelemetry::nostd::string_view Get(
       opentelemetry::nostd::string_view key) const noexcept override
@@ -70,10 +67,10 @@ class GrpcServerCarrier : public opentelemetry::context::propagation::TextMapCar
     // Not required for server
   }
 
-  ServerContext *context_ = nullptr;
+  grpc::ServerContext *context_ = nullptr;
 };
 
-void InitTracer()
+inline void InitTracer()
 {
   auto exporter = opentelemetry::exporter::trace::OStreamSpanExporterFactory::Create();
   auto processor =
@@ -94,17 +91,17 @@ void InitTracer()
           new opentelemetry::trace::propagation::HttpTraceContext()));
 }
 
-void CleanupTracer()
+inline void CleanupTracer()
 {
   std::shared_ptr<opentelemetry::trace::TracerProvider> none;
   opentelemetry::sdk::trace::Provider::SetTracerProvider(none);
 }
 
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(
+inline opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(
     const std::string &tracer_name)
 {
   auto provider = opentelemetry::trace::Provider::GetTracerProvider();
   return provider->GetTracer(tracer_name);
 }
 
-}  // namespace
+}  // namespace grpc_example

examples/http/client.cc

@@ -27,6 +27,8 @@
 #include <type_traits>
 #include <utility>
 
+using namespace http_example;
+
 namespace
 {
 

examples/http/server.cc

@@ -29,6 +29,8 @@
 #include <utility>
 #include "server.h"
 
+using namespace http_example;
+
 namespace
 {
 

examples/http/server.h

@@ -9,7 +9,7 @@
 #include <atomic>
 #include <string>
 
-namespace
+namespace http_example
 {
 
 class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
@@ -28,6 +28,11 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
     server_.setKeepalive(false);
   }
 
+  HttpServer(const HttpServer &)            = delete;
+  HttpServer(HttpServer &&)                 = delete;
+  HttpServer &operator=(const HttpServer &) = delete;
+  HttpServer &operator=(HttpServer &&)      = delete;
+
   void AddHandler(const std::string &path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)
   {
     server_.addHandler(path, *request_handler);
@@ -53,4 +58,4 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
   ~HttpServer() override { Stop(); }
 };
 
-}  // namespace
+}  // namespace http_example

examples/http/tracer_common.h

@@ -22,7 +22,7 @@
 #include "opentelemetry/trace/propagation/http_trace_context.h"
 #include "opentelemetry/trace/provider.h"
 
-namespace
+namespace http_example
 {
 
 template <typename T>
@@ -62,7 +62,7 @@ class HttpTextMapCarrier : public opentelemetry::context::propagation::TextMapCa
   T headers_;
 };
 
-void InitTracer()
+inline void InitTracer()
 {
   auto exporter = opentelemetry::exporter::trace::OStreamSpanExporterFactory::Create();
   auto processor =
@@ -83,17 +83,17 @@ void InitTracer()
           new opentelemetry::trace::propagation::HttpTraceContext()));
 }
 
-void CleanupTracer()
+inline void CleanupTracer()
 {
   std::shared_ptr<opentelemetry::trace::TracerProvider> none;
   opentelemetry::sdk::trace::Provider::SetTracerProvider(none);
 }
 
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(
+inline opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(
     const std::string &tracer_name)
 {
   auto provider = opentelemetry::trace::Provider::GetTracerProvider();
   return provider->GetTracer(tracer_name);
 }
 
-}  // namespace
+}  // namespace http_example