Skip to content

Conversation

LuiseFreese
Copy link

Hey there, hope I did at least SOME things right. Please @marcduiker reach out, will need help with some assets of a lesson :-)

…anaged-identity-powershell.md

basic instructions in the (hopefully) correct folder
Copy link
Owner

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I've added some suggestions. And I'll update/add the deployment lesson for a PS function.

Looks like you renamed the _lesson_template.md file so that's gone now 😬. Can you put the template back for future use? 😉

You can put the source code in this folder: \src\PowerShell\AzureFunctions.ManagedIdentity. Please include the local.settings.json as well (as long as that does not contain any secrets).

Once the sources have been added we can start with CodeTour and Workspaces.


### Steps

1. Install the Core Tools package with `npm install -g azure-functions-core-tools@3 --unsafe-perm true`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can skip 1 and 2 since they are also described in the prerequistes page.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use this formatting to keep the style the same as the other lessons:
https://github.com/marcduiker/azure-functions-university/blob/main/lessons/dotnetcore31/queue/queue-lesson-dotnet.md#steps-1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see. I assumed that you'd do it the docs.microsoft.com way - but happy to adjust :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


See [{language} prerequisites](../prerequisites/prerequisites-{language}.md) for more details.

## 1. Create an Azure Functions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1. Create an Azure Functions
## 1. Create an Azure Functions App

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## 1. Create an Azure Functions

before we will deploy our app to Azure, we will develop it locally in Visual Studio Code. This comes with some great advantages such as
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add a description here what the goal of is this exercise (what is the end result?)
An example: https://github.com/marcduiker/azure-functions-university/blob/main/lessons/dotnetcore31/queue/queue-lesson-dotnet.md#2-using-string-queue-output-bindings

We can drop the general benefits of VS Code here since all the lessons sofar have been done in VSCode.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Steps

```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```console

- permission scope, expressed as App role
Let’s do this:

```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```powershell

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$appRoleId = az ad sp show --id $graphId --query "appRoles[?value=='Group.Read.All'].id | [0]"
```
Time to make the REST call to assign the permissions as shown above to the Managed Identity:
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```powershell

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## 5. Homework

<!-- check with Marc what would be appropriate homework -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a small extension to the function app that doesn't require any new knowledge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓perhaps calling another endpoint of Graph?


## 6. More info
<!--
check with Marc about what should go in this section -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we put links here to MS docs. So in this case any links that have been used before in the text regarding background info on Managed Identities. E.g: https://github.com/marcduiker/azure-functions-university/blob/main/lessons/dotnetcore31/queue/queue-lesson-dotnet.md#9-more-info

@marcduiker
Copy link
Owner

Closed because #92 replaces this PR

@marcduiker marcduiker closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants