Skip to content

do not use pullups which causes the Serial interface not to work anymore #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcel-licence merged 1 commit into from
Mar 10, 2026
Merged

do not use pullups which causes the Serial interface not to work anymore #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/midi_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ void Midi_Setup()
Serial.printf("Setup Serial1 with %d baud with rx: %s%d only\n", MIDI_SERIAL1_BAUDRATE, PIN_CAPTION, MIDI_RX1_PIN);
Serial1.begin(MIDI_SERIAL1_BAUDRATE, SERIAL_8N1, MIDI_RX1_PIN);
#endif
pinMode(MIDI_RX1_PIN, INPUT_PULLUP); /* can be connected to open collector output */
// pinMode(MIDI_RX1_PIN, INPUT_PULLUP); /* can be connected to open collector output */
#else
#ifdef TEENSYDUINO
Serial.printf("Setup Serial1 with %d baud with rx: RX1 pin (PIN 0)\n", MIDI_SERIAL1_BAUDRATE);
Expand Down Expand Up @@ -573,7 +573,7 @@ void Midi_Setup()
#endif
#endif /* MIDI_TX2_PIN */
#if (!defined ARDUINO_RASPBERRY_PI_PICO) && (!defined ARDUINO_GENERIC_RP2040)
pinMode(MIDI_RX2_PIN, INPUT_PULLUP); /* can be connected to open collector output */
// pinMode(MIDI_RX2_PIN, INPUT_PULLUP); /* can be connected to open collector output */
#endif
#else /* MIDI_TX2_PIN */
Serial.printf("Setup Serial2 with %d baud with rx: RX2 pin\n", MIDI_SERIAL2_BAUDRATE);
Expand Down
Loading