Don't limit trade history#839
Conversation
|
Right now there is a consequence that you don't get showed people you traded with in the past, which was useful. For example, I have a single trade pending with 3-4 people and after completing a trade with someone I send them a new one. With this change, the person will disappear from you list as soon as you finish the last trade with them. I think some trade history will be useful, and now we have a chance to implement it more thoughtfully. I think sorting by the number of completed trades is a nice heuristic (if you had many trades with someone, you probably in some sense match you trading preferences with each other). But it can go into the next PR. |
Per my suggestions from #789 (comment) (last point):
Additionally, fixes a bug where trades from people who switched their account back to private were inaccessible, resulting in a badge you can't get rid of. Per the request t/trade-request-from-unknown.