Feature list grammar#41
Open
SerafimArts wants to merge 2 commits intomarcioAlmada:masterfrom
SerafimArts:feature-list-grammar
Open
Feature list grammar#41SerafimArts wants to merge 2 commits intomarcioAlmada:masterfrom SerafimArts:feature-list-grammar
SerafimArts wants to merge 2 commits intomarcioAlmada:masterfrom
SerafimArts:feature-list-grammar
Conversation
Owner
|
Hi! I appreciate the pull request. It seems correct, but we need at least one test before merging. A good place to start is https://github.com/marcioAlmada/yay/blob/master/tests/ParserTest.php 👍 |
marcioAlmada
force-pushed
the
master
branch
2 times, most recently
from
a6a81a0 to
277f52c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second argument of
list()grammar method can be optional now. This feature adds the ability to specify duplicate fragments with a division byT_WHITESPACE(e.g "\n", "\s", etc...).