Open
Conversation
matteoporru
suggested changes
Apr 21, 2020
| @@ -0,0 +1,233 @@ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * | |||
| * Copyright (c) 2019 SAP SE or an affiliate company. All rights reserved. | |||
There was a problem hiding this comment.
The date is invalid (2019).
By the way, should we add the copyright to all files?
|
|
||
| public class ConfigurationHandler { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigurationHandler.class); // logger | ||
| private static final String BASE_PATH = "./../edgeservices/"; // base path for custom configuration, same of other |
There was a problem hiding this comment.
"same of other" is unclear to me what you mean.
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigurationHandler.class); // logger | ||
| private static final String BASE_PATH = "./../edgeservices/"; // base path for custom configuration, same of other | ||
| // services | ||
| private static final String UNIFORM_PATH_SEPARATOR = "/"; // linux/windows valid file separator |
There was a problem hiding this comment.
Why not using the already generic File.separator constant?
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#separator
| defaultConfiguration = loadDefaultConfiguration(); | ||
| } | ||
| // existing file paths | ||
| String jsonFile = BASE_PATH + serviceName + "/" + serviceName + ".json"; |
There was a problem hiding this comment.
use File.separator, or reuse the constant you have defined at the top of the file.
| } | ||
| // existing file paths | ||
| String jsonFile = BASE_PATH + serviceName + "/" + serviceName + ".json"; | ||
| String fingerprintFile = BASE_PATH + serviceName + "/" + serviceName + "_fingerprint.txt"; |
There was a problem hiding this comment.
use File.separator, or reuse the constant you have defined at the top of the file.
Comment on lines
+11
to
+16
| Float variance; | ||
| Float pressureScale; | ||
| Boolean ingestionEnabled; | ||
| Boolean filterMeasurements; | ||
| Boolean filterCalculation; | ||
| List<MessageFilter> filteredObjects; |
Comment on lines
+7
to
+8
| String externalConfigurationTopic; | ||
| String configurationFile; |
Comment on lines
+4
to
+6
| String capabilityAlternateId; | ||
| String sensorAlternateId; | ||
| String sensorTypeAlternateId; |
Comment on lines
+32
to
+34
| TypeReference<HashMap<String, Object>> typeRef = new TypeReference<HashMap<String, Object>>() { | ||
| }; | ||
| Map<String, Object> originalMassageMap = mapper.readValue(mqttMessage.toString(), typeRef); |
There was a problem hiding this comment.
Better:
Map<String, Object > originalMassageMap = mapper.readValue(
mqttMessage.toString(), TypeFactory.mapType(HashMap.class, String.class, Object.class));
| } | ||
|
|
||
| public static void sendMessage(String topic, String content) { | ||
| MqttMessage message = null; |
There was a problem hiding this comment.
= null is redundant here, you can remove it.
Signed-off-by: Marco Porru <marco.porru@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.