Merged
Conversation
Updated multiple YAML files to include a `permissions` section specifying `contents: read`, `packages: write`, and `actions: write`. This change ensures that the workflows have the necessary permissions for successful execution on push to the master branch and manual triggers.
- Refactored `EndpointRouteHandlerGenerator` in `EndpointRouteHandlerGenerator.cs` to improve class processing and validation, and added a method for interface registration. - Removed `TypeDeclarationSyntaxExtensions.cs`, which contained unused extension methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple files to enhance workflow permissions, simplify the codebase, and improve functionality for routing analyzers. The most significant changes include adding permissions to GitHub workflows, transitioning from
.slnto.slnxformat for solution files, refactoring theEndpointRouteHandlerGeneratorclass, and removing unused code.Workflow Enhancements:
.github/workflows/publish_fluentvalidation.yml,.github/workflows/publish_routing.yml,.github/workflows/publish_routing_analyzers.yml,.github/workflows/publish_validation.yml: Added permissions forcontents,packages, andactionsto ensure proper access during publishing workflows. [1] [2] [3] [4]Solution File Transition:
MinimalHelpers.slnand replaced it withMinimalHelpers.slnx, which introduces a more structured and XML-based format for managing projects and solution items. [1] [2]Routing Analyzer Refactor:
src/MinimalHelpers.Routing.Analyzers/EndpointRouteHandlerGenerator.cs: Refactored theEndpointRouteHandlerGeneratorclass to improve readability and functionality. Changes include registering theIEndpointRouteHandlerBuilderinterface during post-initialization, using semantic analysis to identify valid classes, and simplifying the code for generating endpoint mapping logic. [1] [2] [3] [4]Code Cleanup:
src/MinimalHelpers.Routing.Analyzers/TypeDeclarationSyntaxExtensions.csas it contained unused extension methods for syntax analysis.Version Update:
src/MinimalHelpers.Routing.Analyzers/version.json: Updated the version from1.1to1.2to reflect the new changes.