Merged
Conversation
- Updated all projects and libraries to .NET10 - Updated the InstallPlaywrightBackgroundService to respect the new behavior - Updated the workflows and copilot-instructions files
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the PdfSmith application from .NET 9 to .NET 10, updating all project target frameworks, NuGet packages to their .NET 10 compatible versions, and modifying the deployment workflow accordingly.
Key Changes:
- Upgraded all projects from
net9.0tonet10.0target framework - Updated Microsoft and third-party NuGet packages to .NET 10 compatible versions
- Refactored
InstallPlaywrightBackgroundServiceto removeTask.Runwrapper for synchronous Playwright installation - Updated CI/CD workflow to use .NET 10.x SDK
- Updated coding guidelines to reference C# 14 features
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PdfSmith/Program.cs | Changed OpenApi namespace import (potential issue identified) |
| src/PdfSmith/PdfSmith.csproj | Updated target framework to net10.0 and upgraded package versions to 10.0.0 |
| src/PdfSmith/BackgroundServices/InstallPlaywrightBackgroundService.cs | Removed Task.Run wrapper, executing Playwright installation synchronously |
| src/PdfSmith.Shared/PdfSmith.Shared.csproj | Updated target framework to net10.0 |
| src/PdfSmith.DataAccessLayer/PdfSmith.DataAccessLayer.csproj | Updated target framework and EF Core package to net10.0/10.0.0 |
| src/PdfSmith.BusinessLayer/PdfSmith.BusinessLayer.csproj | Updated target framework and related package versions |
| .github/workflows/deploy.yml | Updated .NET version from 9.x to 10.x for Azure deployment |
| .github/copilot-instructions.md | Updated C# version reference from 13 to 14 |
marcominerva
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstallPlaywrightBackgroundServiceclass to respect the newBackgroundServicebehaviorFix #39 and #40