Engine: Make sure validate_ruby also works on older Rubies#1411
Merged
Engine: Make sure validate_ruby also works on older Rubies#1411
validate_ruby also works on older Rubies#1411Conversation
marcoroth
changed the title
validate_ruby also works on older Rubies
marcoroth
changed the title
validate_ruby also works on older Rubiesvalidate_ruby also works on older Rubies
marcoroth
force-pushed
the
engine-syntax-check
branch
from
973daf9 to
c4ea300
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
marcoroth
force-pushed
the
engine-syntax-check
branch
from
c4ea300 to
29e50c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the engine
validate_rubyoption to useRubyVM::InstructionSequence.compileto check for syntax errors, as valid syntax might be depended on the version of Ruby you are running.Resolves #1401