Parser: Don't search for Action View Tag Helpers recursively#1431
Merged
Parser: Don't search for Action View Tag Helpers recursively#1431
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the parser analysis phase with
action_view_helpers: trueenabled wheresearch_tag_helper_nodewould recursively traverse the entire Prism AST of an ERB expression, causing tag helpers nested inside another call's arguments or block body to be incorrectly detected and transformed as the top-level tag helper.For example, the following template:
Would incorrectly transform the
ERBContentNodeas iftag.metawere the outermost call. It now correctly produces the following usingaction_view_helpers: true:The fix stops recursion at any
PM_CALL_NODEthat doesn't match a known tag helper. A tag helper must be the outermost call in the ERB expression, not nested inside another call's arguments or block body.Resolves #1423
Resolves #1429