Linter: group a11y-related rules#1462
Closed
markokajzer wants to merge 1 commit intomarcoroth:mainfrom
Closed
Conversation
5527d4a to
1765df4
Compare
1765df4 to
5da76fc
Compare
Owner
|
Thanks @markokajzer! I think I want to wait with this a little bit before we do a big rename of the linter rule names. But I think for the migration story, we want to utilize the
So that running |
Contributor
Author
|
i'm happy to close this for now then 👍 i'll start adding new related rules under if you want to look into handling of erb for some of these already existing ally rules, feel free to create a separate issue, and i can get going on that as well. thank you mate! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #1310
Group a11y-related rules together and change their prefix from
html-*toa11y-*I was looking at adding more a11y linter rules, so decided to do this cleanup first, so that they're all grouped together.
There might be some additional things that we need to do, as existing config might not work anymore for these rules. technically this is somewhat of a breaking change. what would be the preferred migration strategy?
html-input-require-autocomplete)somewhat related question: i noticed that most of these only operate on
html. however, with the introduction of #1350, their scope could be widened to include ERB tags as well.is that something we would want to look into before introducing new rules? is that something we would want to pay attention to when introducing more a11y rules, like in #177?