Ruby: Introduce depth_limit for Node#tree_inspect#839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a
depth_limitkeyword argument for theNode#tree_inspectmethod. The reason for this is so we don't try to pretty print the whole AST in the terminal, especially on large documents.At some point the output becomes hard to follow anyway and for big documents it takes quite some time to print the full AST, even if you are not even looking at the output. Limiting it, makes sure that you can fast feedback while not trying to print the full AST.
The output now looks like this if the depth limit is reached:
For deeply nested documents (like the one in #828) it went from ~10 s to ~300 ms.