feat(schema): allow set _ignore_default_error to True#416
feat(schema): allow set _ignore_default_error to True#416qfritz wants to merge 2 commits intomarcosschroh:masterfrom
Conversation
|
Ah, deploy preview CI step is broken 🤔 |
Thanks for the PR. I can be a good idea but we need to fix this in a different way. In the AvroSchema.init method you can get the extra The |
marcosschroh
left a comment
There was a problem hiding this comment.
Use the property in the AvroSchema.init _ignore_default_error and use it when creating the schema.
c44ae11 to
4d19c3f
Compare
|
Hi again, thanks for reviewing this PR. |
087a8a3 to
bcd4e4a
Compare
|
Added tests! 🎉 |
_ignore_default_error will ignore errors like:
"Default value must match first schema in union with type: null"
...which I agree are errors but are painful to fix when backporting stuff.
WDYT?