Skip to content

Comments

Update Go linting#7

Merged
marefr merged 1 commit intomarefr:mainfrom
SuperQ:superq/go
Mar 10, 2025
Merged

Update Go linting#7
marefr merged 1 commit intomarefr:mainfrom
SuperQ:superq/go

Conversation

@SuperQ
Copy link

@SuperQ SuperQ commented Mar 10, 2025

  • Set minimum Go version to 1.23.x to match current versions.
  • go mod tidy
  • Enable golangci-lint.
  • Fixup linter issues.

@marefr
Copy link
Owner

marefr commented Mar 10, 2025

Hey @SuperQ long time no see. Thanks. I didn't notice this until after I pushed my golangci-lint changes. Feel free to rebase or let me know and I'll incorporate your changes.

@SuperQ SuperQ force-pushed the superq/go branch 2 times, most recently from c1a0843 to c2b77a2 Compare March 10, 2025 13:32
@SuperQ
Copy link
Author

SuperQ commented Mar 10, 2025

Ok, how about now?

@SuperQ
Copy link
Author

SuperQ commented Mar 10, 2025

Note the SHA pinning of GitHub actions. This is for supply chain security.

* Set minimum Go version to 1.23.x to match current versions.
* `go mod tidy`
* Enable golangci-lint.
* Fixup linter issues.

Signed-off-by: SuperQ <superq@gmail.com>
Copy link
Owner

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr merged commit 8b7b8e0 into marefr:main Mar 10, 2025
2 checks passed
@SuperQ SuperQ deleted the superq/go branch March 10, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants