Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ on:
- '.github/workflows/build-android.yml'
- 'package/cpp/**'
- 'package/android/**'
- 'package/example/android/**'
- 'package/example/AppExampleFabric/android/**'
- 'package/yarn.lock'
- 'package/example/yarn.lock'
pull_request:
paths:
- '.github/workflows/build-android.yml'
- 'package/cpp/**'
- 'package/android/**'
- 'package/example/android/**'
- 'package/example/AppExampleFabric/android/**'
- 'package/yarn.lock'
- 'package/example/yarn.lock'

Expand All @@ -39,7 +39,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
Expand All @@ -49,9 +49,7 @@ jobs:
restore-keys: |
${{ runner.os }}-yarn-
- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd example
run: yarn install --immutable

- name: Restore Gradle cache
uses: actions/cache@v4
Expand All @@ -62,11 +60,11 @@ jobs:
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-
- name: Run Gradle Build for example/android/
run: cd example/android && ./gradlew assembleDebug --build-cache && cd ../..
- name: Run Gradle Build for example/AppExampleFabric/android/
run: cd example/AppExampleFabric/android && ./gradlew assembleDebug --build-cache && cd ../..
- name: Upload .apk to GitHub
uses: actions/upload-artifact@v4
with:
name: Example App (.apk)
path: package/example/android/app/build/outputs/apk/debug/app-debug.apk
path: package/example/AppExampleFabric/android/app/build/outputs/apk/debug/app-debug.apk
if-no-files-found: error
24 changes: 12 additions & 12 deletions .github/workflows/build-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,28 @@ on:
- "package/cpp/**"
- "package/ios/**"
- "package/*.podspec"
- "package/example/ios/**"
- "package/example/AppExampleFabric/ios/**"
pull_request:
paths:
- ".github/workflows/build-ios.yml"
- "package/cpp/**"
- "package/ios/**"
- "package/*.podspec"
- "package/example/ios/**"
- "package/example/AppExampleFabric/ios/**"

jobs:
build:
name: Build iOS Example App
runs-on: macOS-latest
defaults:
run:
working-directory: package/example/ios
working-directory: package/example/AppExampleFabric/ios
steps:
- uses: actions/checkout@v4

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
Expand All @@ -40,7 +40,7 @@ jobs:
restore-keys: |
${{ runner.os }}-yarn-
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd ..
run: yarn install --immutable

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
Expand All @@ -49,14 +49,14 @@ jobs:
- name: Setup Ruby (bundle)
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6.10
ruby-version: 3.4.4
bundler-cache: true
working-directory: package/example/ios
working-directory: package/example/AppExampleFabric/

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: package/example/ios/Pods
path: package/example/ios/AppExampleFabric/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
restore-keys: |
${{ runner.os }}-pods-
Expand All @@ -66,12 +66,12 @@ jobs:
run: gem install xcpretty
- name: Build App
run: "set -o pipefail && xcodebuild \
CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ \
CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ GCC_OPTIMIZATION_LEVEL=0 GCC_PRECOMPILE_PREFIX_HEADER=YES ASSETCATALOG_COMPILER_OPTIMIZATION=time DEBUG_INFORMATION_FORMAT=dwarf COMPILER_INDEX_STORE_ENABLE=NO \
-derivedDataPath build -UseModernBuildSystem=YES \
-workspace RNFFabric.xcworkspace \
-scheme RNFFabric \
-workspace AppExampleFabric.xcworkspace \
-scheme AppExampleFabric \
-sdk iphonesimulator \
-configuration Debug \
-destination 'platform=iOS Simulator,name=iPhone 11 Pro' \
-destination 'platform=iOS Simulator,name=iPhone 16 Pro Max' \
build \
CODE_SIGNING_ALLOWED=NO | xcpretty"
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
cache-dependency-path: docs

- name: Install dependencies
run: yarn install --frozen-lockfile
run: yarn install --immutable
working-directory: docs

- name: Build website
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
cache-dependency-path: docs

- name: Install dependencies
run: yarn install --frozen-lockfile
run: yarn install --immutable
working-directory: docs
- name: Test build website
run: yarn build
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/validate-js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
Expand All @@ -54,9 +54,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example
run: yarn install --immutable

- name: Run TypeScript # Reviewdog tsc errorformat: %f:%l:%c - error TS%n: %m
run: |
Expand All @@ -81,7 +79,7 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
Expand All @@ -92,9 +90,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example
run: yarn install --immutable

- name: Run ESLint
run: yarn lint -f @jamesacarr/github-actions
Expand Down
2 changes: 0 additions & 2 deletions package/example/AppExampleFabric/.bundle/config

This file was deleted.

4 changes: 4 additions & 0 deletions package/example/AppExampleFabric/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
root: true,
extends: '@react-native',
};
1 change: 1 addition & 0 deletions package/example/AppExampleFabric/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ local.properties
.cxx/
*.keystore
!debug.keystore
.kotlin/

# node.js
#
Expand Down
5 changes: 5 additions & 0 deletions package/example/AppExampleFabric/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
arrowParens: 'avoid',
singleQuote: true,
trailingComma: 'all',
};
45 changes: 45 additions & 0 deletions package/example/AppExampleFabric/App.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/**
* Sample React Native App
* https://github.com/facebook/react-native
*
* @format
*/

import { NewAppScreen } from '@react-native/new-app-screen';
import { StatusBar, StyleSheet, useColorScheme, View } from 'react-native';
import {
SafeAreaProvider,
useSafeAreaInsets,
} from 'react-native-safe-area-context';

function App() {
const isDarkMode = useColorScheme() === 'dark';

return (
<SafeAreaProvider>
<StatusBar barStyle={isDarkMode ? 'light-content' : 'dark-content'} />
<AppContent />
</SafeAreaProvider>
);
}

function AppContent() {
const safeAreaInsets = useSafeAreaInsets();

return (
<View style={styles.container}>
<NewAppScreen
templateFileName="App.tsx"
safeAreaInsets={safeAreaInsets}
/>
</View>
);
}

const styles = StyleSheet.create({
container: {
flex: 1,
},
});

export default App;
8 changes: 8 additions & 0 deletions package/example/AppExampleFabric/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,11 @@ ruby ">= 2.6.10"
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
gem 'concurrent-ruby', '< 1.3.4'

# Ruby 3.4.0 has removed some libraries from the standard library.
gem 'bigdecimal'
gem 'logger'
gem 'benchmark'
gem 'mutex_m'
gem 'nkf'
Loading
Loading