Skip to content

fix: stop a crash in HostObject dtor #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boorad merged 2 commits into from
Dec 4, 2024
Merged

fix: stop a crash in HostObject dtor #540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46859c8
fix: stop a crash in HostObject dtor
boorad Dec 4, 2024
d9250c9
undo lockfile changes
boorad Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cpp/JSIUtils/MGLTypedArray.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ class PropNameIDCache {
const jsi::PropNameID &getConstructorNameProp(jsi::Runtime &runtime,
MGLTypedArrayKind kind);

void invalidate() { props.erase(props.begin(), props.end()); }
void invalidate() {
/** This call (and attempts to use props.clear()) crash 💥 when the
* JSI runtime has already been destroyed. So we are commenting it out
* and waiting for Nitro and 1.0 to fix this the proper way.
*/
//props.erase(props.begin(), props.end());
}

private:
std::unordered_map<Prop, std::unique_ptr<jsi::PropNameID>> props;
Expand Down
Loading