-
Notifications
You must be signed in to change notification settings - Fork 108
feat: add ciphers #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add ciphers #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanmav
reviewed
Jan 9, 2025
packages/react-native-quick-crypto/nitrogen/generated/shared/c++/NamedCurve.hpp
Show resolved
Hide resolved
renanmav
reviewed
Jan 9, 2025
8b04a74 to
c69956f
Compare
renanmav
reviewed
Jan 15, 2025
071a068 to
81ccd11
Compare
renanmav
reviewed
Jan 26, 2025
renanmav
reviewed
Jan 26, 2025
81ccd11 to
00b2d7a
Compare
renanmav
reviewed
Jan 29, 2025
renanmav
reviewed
Feb 1, 2025
ae7673f to
6b86ac9
Compare
renanmav
reviewed
Feb 9, 2025
renanmav
reviewed
Feb 11, 2025
renanmav
reviewed
Feb 11, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boorad can you enrich the PR description with more details?
Specifically the differences between cipher modes CCM and OCB. I ask that for future reference.
renanmav
reviewed
Apr 16, 2025
renanmav
reviewed
Apr 16, 2025
renanmav
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ciphers functionality
see implementation-coverage.md for specific classes/functions
Instead of hard-coding a list of cipher algorithms like 0.x, the list is fetched from the installed version of OpenSSL (usually around 100). A few of them were problematic and are left for future tickets:
CTSSIVWRAPSM4For the C++ implementation, we depart a bit from Node and their use of conditionals.
CCMandOCBcipher algorithms were different enough to warrant their own derived classes off of theHybridCipherclass. They override the functions they need, and give warnings via thrown errors back to TS if things are out-of-order. I imagine we will add to these warnings, and possibly refine the tests to be clearer about order of function calls. Of course, library users could always read the Node / OpenSSL documentation 👀