Skip to content

Conversation

@renanmav
Copy link
Contributor

@renanmav renanmav commented Feb 9, 2025

@Bowlerr
Copy link

Bowlerr commented Feb 14, 2025

Hey, great work on this! I was wondering if there is a timeline on when to expect this to be merged and published? I can't wait to test it out @renanmav

@renanmav
Copy link
Contributor Author

@Bowlerr no expectations on timeline here, I work on this on my free time, usually on weekends and evenings.

@renanmav renanmav marked this pull request as ready for review February 23, 2025 21:25
@renanmav renanmav requested a review from boorad February 23, 2025 21:25
@@ -0,0 +1,7 @@
import type { HybridObject } from 'react-native-nitro-modules';

export interface Hmac extends HybridObject<{ ios: 'c++'; android: 'c++' }> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks clean - nice work renan

Copy link
Collaborator

@boorad boorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@boorad boorad merged commit 74b48d8 into main Feb 24, 2025
6 checks passed
@boorad boorad deleted the feat/hmac branch February 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants