MDEV-38550: add LENENC support for COM_CHANGE_USER #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Add CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA support to send_change_user_packet() to allow passwords longer than 255 bytes in COM_CHANGE_USER packets. Previously, send_change_user_packet() only supported single-byte length encoding (max 255 bytes), while send_client_reply_packet() supported LENENC. This caused mysql_change_user() to fail with long passwords when the connection used cleartext auth directly (without auth plugin switching). Note: This fix requires a corresponding server-side fix in parse_com_change_user_packet() to parse LENENC-encoded passwords. Added test case test_change_user_long_pw to verify mysql_change_user() works with 260-byte passwords.
rophy
force-pushed
the
fix/MDEV-38431-lenenc-change-user
branch
from
f9590ff to
057000e
Compare
rophy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MariaDB/server#4534
Add CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA support to send_change_user_packet()
to allow passwords longer than 255 bytes in COM_CHANGE_USER packets.
Previously, send_change_user_packet() only supported single-byte length
encoding (max 255 bytes), while send_client_reply_packet() supported LENENC.
This caused mysql_change_user() to fail with long passwords when the
connection used cleartext auth directly (without auth plugin switching).
Note: This fix requires a corresponding server-side fix in
parse_com_change_user_packet() to parse LENENC-encoded passwords.