Merged
Conversation
Contributor
Author
|
Been facing issues with [W 250212 22:00:30 sandbox:120] Failed to read dependencies from .\03_probability_of_or.pyFinally resulting in: File "C:\Python311\Lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 9101: character maps to <undefined>Will inline the dependencies manually for now? |
akshayka
reviewed
Feb 13, 2025
Contributor
akshayka
left a comment
There was a problem hiding this comment.
This is fantastic! Tiny comments. Great work. I like the balance of clear exposition, code examples, and a compelling interactive lesson (venn diagrams). Minor suggestion, use width medium so the venn diagram example is more legible?
…rimo-team/learn into haleshot/03_probability_of_Or
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Used the Probability of
ORchapter as the base reference to get a good interactive notebook running. Good examples with relevant LaTeX text and python functions.📋 Checklist
--sandboxREADME.md