Skip to content

Add probability of OR notebook#32

Merged
akshayka merged 4 commits intomainfrom
haleshot/03_probability_of_Or
Feb 13, 2025
Merged

Add probability of OR notebook#32
akshayka merged 4 commits intomainfrom
haleshot/03_probability_of_Or

Conversation

@Haleshot
Copy link
Contributor

@Haleshot Haleshot commented Feb 12, 2025

📝 Summary

Used the Probability of OR chapter as the base reference to get a good interactive notebook running. Good examples with relevant LaTeX text and python functions.

📋 Checklist

  • I have included package dependencies in the notebook file using --sandbox
  • If adding a course, include a README.md
  • Keep language direct and simple.

@Haleshot Haleshot self-assigned this Feb 12, 2025
@Haleshot Haleshot requested a review from akshayka February 12, 2025 16:28
@Haleshot
Copy link
Contributor Author

Been facing issues with --sandbox and uvx marimo edit for a while now.
Always seem to run into this error:

[W 250212 22:00:30 sandbox:120] Failed to read dependencies from .\03_probability_of_or.py

Finally resulting in:

File "C:\Python311\Lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 9101: character maps to <undefined>

Will inline the dependencies manually for now?

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Tiny comments. Great work. I like the balance of clear exposition, code examples, and a compelling interactive lesson (venn diagrams). Minor suggestion, use width medium so the venn diagram example is more legible?

Haleshot and others added 3 commits February 13, 2025 13:55
@akshayka akshayka merged commit 9489c61 into main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants