-
Notifications
You must be signed in to change notification settings - Fork 861
marimo/_runtime/packages/module_name_to_pypi_name.py: Add mapping for sage
#7151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| "rsbackends": "RSFile", | ||
| "ruamel": "ruamel.base", | ||
| "saga": "saga-python", | ||
| "sage": "passagemath-standard", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Isn't the standard distribution sagemath-standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sagemath-standard was discontinued by the SageMath project after August 2025, see https://pypi.org/project/sagemath-standard/#history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SageMath project now provides only https://pypi.org/project/sagemath, but that does not provide binary wheels, as can be seen in https://pypi.org/project/sagemath/#files, so it is not suitable in the molab cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. We can also pre-package the bins for molab, but I think the official sage distribution is what most users would expect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The official Sage distribution is not compatible (any more...) with installation via pip / uv.
Edit: see passagemath/passagemath#1508 (comment)
|
I'm going to close this out in favour of #7153 - but thank you for your enthusiasm. We'll make sure that sage works seamlessly on molab |
|
I strongly recommend actually testing the "sage" build via As you can see in the instructions that the person there is referring to, numerous dependencies (system packages) need to be installed, either using conda, or from a suitable Linux distribution before "pip install" / "uv install" can succeed. It will also need these system packages at runtime, not just a prebuilt wheel. It is unlikely that the marimo project will want to take on the maintenance of this. Claims that the SageMath project is "working on providing binary wheels" are false. On the contrary, the existing infrastructure for making binary wheels, such as https://pypi.org/project/sagemath-objects/10.5/#files (from December 2024), was discontinued in early 2025. References on this: |
📝 Summary
Map the namespace
sageto the package https://pypi.org/project/passagemath-standard/🔍 Description of Changes
The default mapping by marimo for the namespace
sageleads to the uninstallable dummy package https://pypi.org/project/sage/Following the instructions at https://docs.marimo.io/guides/editor_features/package_management/, this PR provides a mapping of the namespace
sageto the pip-installable package passagemath-standard, which provides this namespace via its numerous dependencies, each pip-installable from binary wheels on PyPI. @akshaykaFor a more fine-grained mapping to the modularized pip-installable packages of passagemath, progress on the following issue will be needed.
📋 Checklist