Skip to content

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Nov 26, 2025

📝 Summary

PRs must have a label of type: enhancement','bug','documentation','internal','preview','other

or an error will be raised with message:
"Select at least one label ['enhancement','bug','documentation','internal','preview','other']"

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 1, 2025 6:28pm

enforce-label:
runs-on: ubuntu-latest
steps:
- uses: yogevbd/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for colocation, maybe this can live with .github/workflows/labeler.yml? maybe its even better to run this after the auto-labeler

@Light2Dark Light2Dark marked this pull request as ready for review November 26, 2025 19:21
@Light2Dark Light2Dark requested a review from manzt as a code owner November 26, 2025 19:21
@Light2Dark Light2Dark marked this pull request as draft November 26, 2025 19:22
@Light2Dark Light2Dark marked this pull request as ready for review December 1, 2025 15:49
@Light2Dark Light2Dark changed the title test enforcing labels in PR before merge enforcing labels in PR before merge Dec 1, 2025
@mscolnick
Copy link
Contributor

@manzt what do you think?

@manzt
Copy link
Contributor

manzt commented Dec 1, 2025

Looks great. Do we want to add a other label for things that don't fit with these labels? Right now, anything that isn't explicitly labeled is filed under "other" in the release notes (instead of ignored like with internal).

We don't need to change anything else about the release notes gen because the label is unused, but it could go here.

@Light2Dark Light2Dark added good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 1, 2025
@Light2Dark Light2Dark added enhancement New feature or request browser:firefox Please let us know if this affects other browsers too internal A refactor or improvement that is not user facing and removed enhancement New feature or request browser:firefox Please let us know if this affects other browsers too labels Dec 1, 2025
@mscolnick mscolnick merged commit afb4adc into main Dec 1, 2025
39 of 44 checks passed
@mscolnick mscolnick deleted the sham/force-pr-labels-before-merge branch December 1, 2025 19:00
mscolnick added a commit that referenced this pull request Dec 1, 2025
mscolnick added a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants