-
Notifications
You must be signed in to change notification settings - Fork 860
feature: generate additional comments during jupyer2marimo notebook converter (for modified or redefined variables) #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA |
dmadisetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Noticed a slight discrepancy in the tests.
If this is for reconstruction, then we need to account for in place operations
# ie
x += 1
# vs
x = x + 1|
@dmadisetti is the PR ok from your side ? |
|
Thanks for checking in @bmerkle I think this might add a lot of noise without a ton of value to the user. The benefit I see from doing something like this is that we could potentially exactly reconstruct the ipynb output in addition to letting the user know there's been a change. But! This is implementation is lacking since it still doesn't distinguish in-place operations. # originally: x += 1
x_1 = x + 1 # No double stacking comments!Thoughts? @akshayka may also have ideas- but hold off on implementation and we can discuss. Thanks for taking the initiative though! |
|
@dmadisetti thanks for the feedback. I will hold off implementation until we have agreed on the best approach. @akshayka The idea was to make it more transparent to the user, where the code came from during the conversion. we can also chat at discord if that is more efficient |
📝 Summary
Enhanced variable renaming with contextual comments during Jupyter → marimo conversion.
When variables are renamed, modified, or redefined as part of the conversion process, explanatory comments are automatically attached. This improves traceability, preserves intent, and makes the resulting marimo notebook easier to understand and review—especially for non-trivial refactorings introduced during conversion.
🔍 Description of Changes
📋 Checklist