-
Notifications
You must be signed in to change notification settings - Fork 858
Fix group dependency upgrade #7681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
3071a35 to
c71782c
Compare
for more information, see https://pre-commit.ci
.../components/app-config/optional-features.tsx | 2 +-
.../editor/chrome/panels/packages-panel.tsx | 20 +++++--
marimo/_runtime/packages/conda_package_manager.py | 14 +++--
marimo/_runtime/packages/package_manager.py | 16 +++---
marimo/_runtime/packages/pypi_package_manager.py | 66 +++++++++++-----------
marimo/_server/api/endpoints/packages.py | 8 +--
marimo/_server/models/packages.py | 4 +-
tests/_runtime/packages/test_package_managers.py | 8 +--
.../_runtime/packages/test_pypi_package_manager.py | 20 +++----
tests/_server/api/endpoints/test_packages.py | 18 +++---
10 files changed, 93 insertions(+), 83 deletions(-)
|
for more information, see https://pre-commit.ci
|
@Deufel - apologies we haven't gotten to reviewing this yet. we are prepping for a large release and has been taking a lot of our time. we should hopefully have time end of this week or early next week |
|
O no worries at all, thanks letting me know 👍 |
📝 Summary
🔍 Description of Changes
Backend
Replaced
dev: boolparameter withgroup: Optional[str] = Noneacross package managers and API endpointsFrontend
Updated
UpgradeButton,RemoveButton, andInstallButtonto extract and pass the group from package tagsTests: Updated to use
group="dev"instead ofdev=True, No New TestsThis is a breaking change to the internal API, but generalizes the previous dev-only behavior to support arbitrary dependency groups.
📋 Checklist