Skip to content

add bedrock provider, simplify abstract class #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Light2Dark merged 4 commits into from
Jan 8, 2026
Merged

add bedrock provider, simplify abstract class #7707

Light2Dark merged 4 commits into from
Jan 8, 2026

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Jan 7, 2026

📝 Summary

image

Updated the config to pull region_name, because region_name is needed when creating Bedrock Models.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Jan 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 8, 2026 3:13am

Light2Dark
Light2Dark commented Jan 7, 2026
View reviewed changes
marimo/_server/ai/providers.py
provider=self.provider,
settings=BedrockModelSettings(
max_tokens=max_tokens,
# TODO: Add reasoning support
Copy link
Contributor Author

@Light2Dark Light2Dark Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't have reasoning before, so I did not add new logic to support this.

@Light2Dark Light2Dark requested a review from akshayka as a code owner January 7, 2026 14:11
@Light2Dark Light2Dark added the internal A refactor or improvement that is not user facing label Jan 7, 2026
mscolnick
mscolnick previously approved these changes Jan 7, 2026
View reviewed changes
mscolnick
mscolnick previously approved these changes Jan 7, 2026
View reviewed changes
@mscolnick
Copy link
Contributor

mscolnick commented Jan 7, 2026 

FAILED tests/_server/ai/test_providers.py::test_get_completion_provider[bedrock] - marimo._dependencies.errors.ManyModulesNotFoundError: The following packages are required for AI assistance: pydantic_ai, boto3
```

@Light2Dark Light2Dark force-pushed the sham/add-bedrock-pydantic branch from 482c950 to 7d1979a Compare January 8, 2026 03:12
@Light2Dark Light2Dark merged commit c9302e5 into main Jan 8, 2026
51 of 70 checks passed
@Light2Dark Light2Dark deleted the sham/add-bedrock-pydantic branch January 8, 2026 04:23
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

@akshayka akshayka Awaiting requested review from akshayka akshayka is a code owner

Assignees

No one assigned

Labels

internal A refactor or improvement that is not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick