fix: support for updated marimo HTML structure (v0.14.0+) in VSCode extension #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello marimo team,
Thank you for the great work on marimo!
Starting with marimo v0.14.0 (see marimo-team/marimo#5120), the HTML structure of marimo notebooks has changed. In previous versions, information such as the server token was embedded in custom
<marimo-*>tags. However, from v0.14.0 onward, this data is now passed via a<script>tag containing a JavaScript object.The marimo VSCode extension currently relies on the previous structure, extracting required data from the custom elements. As a result, upgrading marimo to v0.14.0 or later causes the notebook to fail to render properly inside the VSCode notebook interface.
This PR updates the extension to support the new HTML structure, allowing it to correctly parse the necessary information and display marimo notebooks in VSCode when using marimo v0.14.0 or later.
Please let me know if any changes or additional tests are needed. I'm happy to revise this PR accordingly.
Thank you!