Add Nemotron Pretraining Code v1 to pretraining dataset registry#2751
Open
Add Nemotron Pretraining Code v1 to pretraining dataset registry#2751
Conversation
Contributor
|
Claude finished @dlwh's task in 43s —— View job Review: Add Nemotron Pretraining Code v1Adds download and tokenize wiring for
Findings: No issues found. The implementation is consistent with other simple dataset entries:
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds wiring for
nvidia/Nemotron-Pretraining-Code-v1in the pretraining dataset registry so it can be downloaded and tokenized through the standardexperiments/pretraining_datasetsCLI.The new dataset entry targets the
Synthetic-Codeconfig (the only config with atextfield) and excludes the metadata-only config by restricting HF download globs toSynthetic-Code/*.parquetplus dataset docs.Changes:
downloads["nemotron_pretraining_code_v1"]inexperiments/pretraining_datasets/simple.pytokenized["nemotron_pretraining_code_v1"]inexperiments/pretraining_datasets/simple.pynemotron_pretraining_code_v1inexperiments/pretraining_datasets/__init__.pyValidation:
uv run experiments/pretraining_datasets/main.py list./infra/pre-commit.py experiments/pretraining_datasets/simple.py experiments/pretraining_datasets/__init__.pyuv run python - <<'PY' ... get_steps(['nemotron_pretraining_code_v1'], download=True, tokenize=True) ... PY